Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gnohealth cli tool #3158

Merged
merged 2 commits into from
Nov 20, 2024
Merged

feat: add gnohealth cli tool #3158

merged 2 commits into from
Nov 20, 2024

Conversation

aeddi
Copy link
Contributor

@aeddi aeddi commented Nov 19, 2024 •
edited
Loading

This PR adds a tool to the contribs dedicated to adding subcommands for health checks. The first available subcommand simply detects timestamp drift on a given chain.

This test was useful in the context of this issue: #1950.

However, it could later run on a dedicated server or on a GitHub Actions cron job to alert us in case significant drift occurs again.

Results on test5 :

> gnohealth timestamp -ws -remote 'wss://rpc.test5.gno.land:443/websocket' -verbose
block 411344 drifted of 3.094940942s (max 10s): OK
block 411345 drifted of 2.368750176s (max 10s): OK
block 411346 drifted of 2.310184977s (max 10s): OK
block 411347 drifted of 2.158713327s (max 10s): OK
block 411348 drifted of 2.203484957s (max 10s): OK
block 411349 drifted of 2.156479203s (max 10s): OK
block 411350 drifted of 2.155613458s (max 10s): OK
block 411351 drifted of 2.296832155s (max 10s): OK
block 411352 drifted of 2.132230389s (max 10s): OK
block 411353 drifted of 2.181071735s (max 10s): OK
block 411354 drifted of 2.575055701s (max 10s): OK
block 411355 drifted of 2.034728695s (max 10s): OK
block 411356 drifted of 2.285932658s (max 10s): OK
block 411357 drifted of 2.330991247s (max 10s): OK
block 411358 drifted of 2.365136593s (max 10s): OK
block 411359 drifted of 2.035198868s (max 10s): OK
block 411360 drifted of 2.128274141s (max 10s): OK
block 411361 drifted of 2.48608003s (max 10s): OK
block 411362 drifted of 2.072144703s (max 10s): OK
block 411363 drifted of 2.297280076s (max 10s): OK
block 411364 drifted of 2.224310386s (max 10s): OK
no timestamp drifted beyond the maximum delta (average 2.280639734s)

Results on test4 :

> gnohealth timestamp -ws -remote 'wss://rpc.test4.gno.land:443/websocket' -verbose
block 3618022 drifted of 3.765561468s (max 10s): OK
block 3618023 drifted of 3.697091353s (max 10s): OK
block 3618024 drifted of 3.576602477s (max 10s): OK
block 3618025 drifted of 3.542585771s (max 10s): OK
block 3618026 drifted of 3.72231133s (max 10s): OK
block 3618027 drifted of 3.751154575s (max 10s): OK
block 3618028 drifted of 8.312827308s (max 10s): OK
block 3618029 drifted of 3.712806121s (max 10s): OK
block 3618030 drifted of 3.65324572s (max 10s): OK
no timestamp drifted beyond the maximum delta (average 4.192687347s)
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.79%. Comparing base (b3800b7) to head (78d0c41).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3158      +/-   ##
==========================================
- Coverage   63.80%   63.79%   -0.01%     
==========================================
  Files         549      549              
  Lines       78833    78833              
==========================================
- Hits        50301    50295       -6     
- Misses      25143    25146       +3     
- Partials     3389     3392       +3
Flag Coverage Δ
contribs/gnodev 60.54% <ø> (-0.63%) ⬇️
contribs/gnofaucet 15.77% <ø> (+0.94%) ⬆️
gno.land 73.70% <ø> (ø)
gnovm 67.94% <ø> (ø)
tm2 62.42% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@aeddi aeddi mentioned this pull request Nov 19, 2024
Closed
moul
moul reviewed Nov 19, 2024
View reviewed changes
contribs/gnohealth/go.mod Outdated Show resolved Hide resolved
@aeddi aeddi merged commit 7188b1c into gnolang:master Nov 20, 2024
140 checks passed
@aeddi aeddi deleted the dev/aeddi/gnohealth branch November 20, 2024 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

Assignees

@aeddi aeddi

Labels
None yet
Projects
🧙‍♂️gno.land core team
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeddi @moul